Enable uncaught error capture for web workers #929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
window
anddocument
, so non-window global objects work correctly. With this bug fixed,captureUncaught
can be set in a Web Worker’s Rollbar instance and errors will be reported with full stack information.prepareStackTrace()
.Currently there aren't tests specifically for web workers. I looked into whether this is possible with the current Karma test framework, and ran into problems stubbing interfaces in the separate worker context. For now the functionality has been tested manually.
Type of change
Related issues
Fixes ch80345
Development
Code review